-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement compact encoding scheme for partial tries. #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I put a few question or suggestion or just general self comment (I will put them in resolve status).
I did play a bit with the pr on jimpo/trie-codec...cheme:try_compact_proof .
I still did not look at the 'Extension' management (I only focused on the branch only case).
} | ||
} | ||
NodePlan::Branch { .. } => { | ||
if child_prefix.len() <= self.prefix.len() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could just debug_assert that (the function is only call with expect).
As per module doc: