Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: allow for custom error codes from Parse Cloud #165

Merged
merged 11 commits into from
Jun 17, 2021

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jun 16, 2021

Closes #164

@cbaker6 let me know your thoughts!

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #165 (0faebdc) into main (603486a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files          70       70           
  Lines        6584     6596   +12     
=======================================
+ Hits         5409     5419   +10     
- Misses       1175     1177    +2     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseError.swift 100.00% <100.00%> (+20.00%) ⬆️
...t/LiveQuery/Protocols/ParseLiveQueryDelegate.swift 0.00% <0.00%> (-20.00%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 74.83% <0.00%> (-0.33%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 77.27% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603486a...0faebdc. Read the comment docs.

@cbaker6
Copy link
Contributor

cbaker6 commented Jun 16, 2021

@dblythy I made some updates to better fit the SDK. I'll make some comments on the rest

@cbaker6
Copy link
Contributor

cbaker6 commented Jun 16, 2021

@TomWFox can you checkout the added documentation?

Co-authored-by: Corey <coreyearleon@icloud.com>
Co-authored-by: Corey <coreyearleon@icloud.com>
@cbaker6
Copy link
Contributor

cbaker6 commented Jun 17, 2021

@dblythy looking good, can you add a changelog entry?

@cbaker6 cbaker6 merged commit 457ef7c into parse-community:main Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Swift can't decode custom ParseCloud errors
3 participants