Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change boolean config params to match Swift #311

Merged
merged 1 commit into from
Jan 3, 2022
Merged

refactor: change boolean config params to match Swift #311

merged 1 commit into from
Jan 3, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 3, 2022

New Pull Request Checklist

Issue Description

Boolean config parameters should began with is to match standard Swift conventions.

Related issue: #n/a

Approach

Change the relevant config parameters. This is a breaking change, but the compiler should help update the names.

Changes you will need to make to your ParseSwift initialization/configuration:

  • deleteKeychainIfNeeded -> isDeletingKeychainIfNeeded
  • useTransactions -> isUsingTransactions
  • allowCustomObjectId -> isAllowingCustomObjectIds

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 3, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #311 (2ee5ab8) into main (6a7f5c7) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   84.59%   84.67%   +0.07%     
==========================================
  Files         114      114              
  Lines       11700    11701       +1     
==========================================
+ Hits         9898     9908      +10     
+ Misses       1802     1793       -9     
Impacted Files Coverage Δ
...s/ParseSwift/Objects/ParseInstallation+async.swift 100.00% <ø> (ø)
...ParseSwift/Objects/ParseInstallation+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject+async.swift 100.00% <ø> (ø)
...urces/ParseSwift/Objects/ParseObject+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 81.46% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.27% <ø> (ø)
Sources/ParseSwift/API/API+Command.swift 83.80% <100.00%> (+0.03%) ⬆️
Sources/ParseSwift/Coding/ParseEncoder.swift 74.23% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 80.66% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7f5c7...2ee5ab8. Read the comment docs.

@cbaker6 cbaker6 merged commit 4c611ac into parse-community:main Jan 3, 2022
@cbaker6 cbaker6 deleted the refactorNames branch January 3, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant