Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server responses and saving of ParseObjects #34

Merged
merged 22 commits into from
Dec 17, 2020
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Dec 13, 2020

  • show fetching example of server updates not being saved on local device (commit). Fixed by removing FetchResponse (commit)
  • persist server response of all ParseObjects during fetch and fetchAll. fetchAll in the JS and Objc API's query for fetch based on a list of objectIds. Parse-Swift does the samething now. FetchResponse was deleted as it's not needed and isn't versatile enough to support all ParseObjects.
  • add deleteAll
  • add/tested playgrounds examples of sync/async: fetch, fetchAll, deleteAll
  • clean up CI

@cbaker6 cbaker6 marked this pull request as draft December 13, 2020 17:27
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #34 (8723753) into main (0e91753) will increase coverage by 0.17%.
The diff coverage is 73.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   71.46%   71.64%   +0.17%     
==========================================
  Files          30       30              
  Lines        1791     1862      +71     
==========================================
+ Hits         1280     1334      +54     
- Misses        511      528      +17     
Impacted Files Coverage Δ
Sources/ParseSwift/API/BatchUtils.swift 77.77% <0.00%> (+14.14%) ⬆️
Sources/ParseSwift/API/Responses.swift 54.16% <ø> (-7.91%) ⬇️
...ources/ParseSwift/Object Protocols/ParseUser.swift 80.45% <ø> (ø)
Sources/ParseSwift/API/API+Commands.swift 63.30% <73.07%> (+1.12%) ⬆️
...rces/ParseSwift/Object Protocols/ParseObject.swift 78.54% <75.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e91753...8723753. Read the comment docs.

@cbaker6 cbaker6 marked this pull request as ready for review December 15, 2020 00:56
@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 15, 2020

@TomWFox can you look over the docs and some of the throw errors I added? I particularly added new documentation for deleteAll and added warnings to both fetchAlls.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 15, 2020

@pranjalsatija can you review this?

@cbaker6 cbaker6 requested a review from TomWFox December 15, 2020 01:02
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good 👍

@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 16, 2020

@TomWFox can you change the branch protections from "deploy_docs" to "docs"?

@cbaker6 cbaker6 merged commit ea76851 into main Dec 17, 2020
@cbaker6 cbaker6 deleted the fixServerResponses branch December 17, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants