-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add discardableResult to ParseObject methods #385
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 89.66% 89.64% -0.03%
==========================================
Files 155 155
Lines 14121 14121
==========================================
- Hits 12662 12659 -3
- Misses 1459 1462 +3
Continue to review full report at Codecov.
|
@cbaker6 Could you help me point why the tests are failing? But I don't think that has anything to do with the little changes I made |
I wouldn’t worry about the failing tests on your system if they aren’t showing up in the CI. What does show in the CI looks like you didn’t lint the project after your changes. You will need to fix linting before this can be merged. |
@cbaker6 I'm testing this line: |
This is a random failure that only occurs in the CI so you can ignore. Can you add |
Now something is wrong with linux? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
New Pull Request Checklist
Issue Description
If you want to execute save() or fetch(),... the function returns the ParseObject. If you don't need it you need to cancel it out with an underscore replacement.
Related issue: #384
Approach
@discardableResult
adds the possibility to skip the result as developer.It's up to the developer to decide whether they use the result or not.
TODOs before merging