Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes npm git necessity #4853

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Removes npm git necessity #4853

merged 1 commit into from
Jun 26, 2018

Conversation

flovilmart
Copy link
Contributor

No description provided.

@flovilmart flovilmart requested a review from dplewis June 25, 2018 19:03
@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #4853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4853   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         119      119           
  Lines        8760     8760           
=======================================
  Hits         8127     8127           
  Misses        633      633

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64388a3...1752e76. Read the comment docs.

@dplewis
Copy link
Member

dplewis commented Jun 25, 2018

Sorry I’m not at a computer right now to do a proper review.

Update the version in package.json

Update the Master Full Change log to latest version.

My main question is what will happen when you deploy master branch to npm?

@flovilmart
Copy link
Contributor Author

Update the version in package.json
Update the Master Full Change log to latest version.

I don't intend to make a release, just have the changelog set so there's no need to make it after ;)

My main question is what will happen when you deploy master branch to npm?

nothing, I mean it will just make a release and that's it ;)

@dplewis
Copy link
Member

dplewis commented Jun 25, 2018

Sorry I’m slow on the uptake

@flovilmart flovilmart merged commit e15244c into master Jun 26, 2018
@flovilmart flovilmart deleted the improvement/remove-npm-git branch June 26, 2018 00:59
flovilmart added a commit that referenced this pull request Aug 12, 2018
flovilmart added a commit that referenced this pull request Aug 12, 2018
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants