Ensure legacy users with authData are not locked out #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
force-pushed
the
fix/issue-4897
branch
from
cabeb23 to
8b0192e
Compare
flovilmart
changed the title
|
I confirm this solves #4897 |
dplewis
suggested changes
Jul 18, 2018
src/RestWrite.js
Outdated
| } | ||
| return objects.filter((object) => { | ||
| if (!object.ACL) { | ||
| return true; // legacu users that have no ACL field on them |
flovilmart
force-pushed
the
fix/issue-4897
branch
from
8b0192e to
a79f576
Compare
Codecov Report
@@ Coverage Diff @@
## master #4898 +/- ##
==========================================
- Coverage 92.92% 92.87% -0.06%
==========================================
Files 119 119
Lines 8830 8836 +6
==========================================
+ Hits 8205 8206 +1
- Misses 625 630 +5
Continue to review full report at Codecov.
|
dplewis
approved these changes
Jul 18, 2018
flovilmart
added a commit
that referenced
this pull request
Aug 12, 2018
* Adds fix for issue, ensuring legacy users with no ACL are properly handled * Runs tests only on mongo
flovilmart
added a commit
that referenced
this pull request
Aug 12, 2018
* Adds fix for issue, ensuring legacy users with no ACL are properly handled * Runs tests only on mongo
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
…#4898) * Adds fix for issue, ensuring legacy users with no ACL are properly handled * Runs tests only on mongo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4897
When adding the feature with user lockout, this added an issue as legacy users, ones without ACL's would be locked out of their account, unable to login.
The fix is to ignore those accounts where the ACL is undefined and not treat it as a locked out ACL.