Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures the test suites are properly formed for vscode jasmine plugin #4901

Merged
merged 3 commits into from
Jul 19, 2018

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Jul 18, 2018

  • Cosmetic changes to tests so jasmine testing works well.
  • Removes duplicated test cases.

@flovilmart flovilmart force-pushed the improvements/tests branch from 3683bd3 to 83b7687 Compare July 18, 2018 13:00
@flovilmart flovilmart requested a review from dplewis July 18, 2018 13:01
@dplewis
Copy link
Member

dplewis commented Jul 18, 2018

@flovilmart I've had this issue where my tests don't show up in the jasmine test explorer is the PR suppose to fix that or something else.

@flovilmart
Copy link
Contributor Author

flovilmart commented Jul 18, 2018

It ensures that the describe_only_db, it_only_db etc... have the proper location in code.

For your issue, is comes from a recent version from jasmine test explorer where the reporters are cleared in our helper.js, which clears the reporter responsible for listing the tests :/ It broke recently.

On our side we could go back to the dot reporter, as we don't really need the spec one.

It also deduplicates some test names.

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #4901 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4901      +/-   ##
==========================================
- Coverage   92.92%   92.89%   -0.04%     
==========================================
  Files         119      119              
  Lines        8836     8836              
==========================================
- Hits         8211     8208       -3     
- Misses        625      628       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 91.27% <0%> (-0.75%) ⬇️
src/RestWrite.js 93.32% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb6c63...a82363f. Read the comment docs.

dplewis
dplewis previously approved these changes Jul 18, 2018
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flovilmart flovilmart merged commit a2c4036 into master Jul 19, 2018
@flovilmart flovilmart deleted the improvements/tests branch July 19, 2018 07:05
flovilmart added a commit that referenced this pull request Aug 12, 2018
…#4901)

* Ensures the test suites are properly formed for vscode jasmine plugin

* nit
flovilmart added a commit that referenced this pull request Aug 12, 2018
…#4901)

* Ensures the test suites are properly formed for vscode jasmine plugin

* nit
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
…parse-community#4901)

* Ensures the test suites are properly formed for vscode jasmine plugin

* nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants