-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensures the test suites are properly formed for vscode jasmine plugin #4901
Conversation
flovilmart
commented
Jul 18, 2018
•
edited
Loading
edited
- Cosmetic changes to tests so jasmine testing works well.
- Removes duplicated test cases.
3683bd3
to
83b7687
Compare
@flovilmart I've had this issue where my tests don't show up in the |
It ensures that the describe_only_db, it_only_db etc... have the proper location in code. For your issue, is comes from a recent version from On our side we could go back to the dot reporter, as we don't really need the spec one. It also deduplicates some test names. |
Codecov Report
@@ Coverage Diff @@
## master #4901 +/- ##
==========================================
- Coverage 92.92% 92.89% -0.04%
==========================================
Files 119 119
Lines 8836 8836
==========================================
- Hits 8211 8208 -3
- Misses 625 628 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…#4901) * Ensures the test suites are properly formed for vscode jasmine plugin * nit
…#4901) * Ensures the test suites are properly formed for vscode jasmine plugin * nit
…parse-community#4901) * Ensures the test suites are properly formed for vscode jasmine plugin * nit