Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Object not found." instead of "Insufficient auth." when using master key #5133

Conversation

georgesjamous
Copy link
Contributor

@georgesjamous georgesjamous commented Oct 19, 2018

A minor change that will return "Object not found.", instead of "Insufficient auth." when using a master key. Which seems to be more appropriate since the masterKey has the highest authority.
Issue: #5129

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #5133 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5133   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         123      123           
  Lines        8923     8923           
=======================================
  Hits         8374     8374           
  Misses        549      549
Impacted Files Coverage Δ
src/rest.js 98.85% <100%> (+1.14%) ⬆️
src/RestWrite.js 92.88% <0%> (-0.55%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.08% <0%> (-0.09%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.25% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c692f07...08cf384. Read the comment docs.

@dplewis dplewis requested a review from flovilmart October 22, 2018 23:18
@flovilmart
Copy link
Contributor

Thanks @georgesjamous!

@flovilmart flovilmart merged commit 961abda into parse-community:master Oct 22, 2018
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
… key (parse-community#5133)

* add additional isMaster check

* adding some tests

* nits

* covering all basis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants