Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MongoDB to 3.3.5 #6263

Merged
merged 9 commits into from
Dec 7, 2019
Merged

Update MongoDB to 3.3.5 #6263

merged 9 commits into from
Dec 7, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Dec 5, 2019

Closes: #6261, #6041

This is a work in progress, any help will be appreciated

Unified Topology Guide

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #6263 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6263      +/-   ##
==========================================
+ Coverage   93.79%   93.81%   +0.01%     
==========================================
  Files         169      169              
  Lines       11564    11564              
==========================================
+ Hits        10847    10849       +2     
+ Misses        717      715       -2
Impacted Files Coverage Δ
src/ParseServer.js 91.56% <0%> (-6.03%) ⬇️
src/Controllers/DatabaseController.js 95.01% <0%> (+0.17%) ⬆️
src/RestWrite.js 93.75% <0%> (+0.32%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.74% <0%> (+1.63%) ⬆️
src/ParseServerRESTController.js 98.18% <0%> (+1.81%) ⬆️
src/batch.js 91.83% <0%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa5e3f5...38404ee. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Dec 6, 2019

@acinader @davimacedo The tests pass locally for me. I can't replicate the travis failing tests.

@davimacedo
Copy link
Member

Travis is really strange recently. I am trying to figure it out.

@dplewis
Copy link
Member Author

dplewis commented Dec 6, 2019

@davimacedo This error occurs for me when I run the entire test suite instead of individual files

@dplewis
Copy link
Member Author

dplewis commented Dec 6, 2019

@acinader @davimacedo I don't know why xit that test fixed this.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@davimacedo davimacedo merged commit 3de12fa into master Dec 7, 2019
@dplewis dplewis deleted the mongodb-3.3.5 branch December 7, 2019 00:08
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Update MongoDB to 3.3.5

* xit

* try again

* set timeout for tests

* remove flaky test

* Update package-lock.json

* fix conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongodb: 3.3.2 driver unable to connect with replica set when one node is down.
2 participants