-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tools)!: docs and demos refactor #2059
Conversation
but explicitly render styles demo
Lifts async file access work to the cem 11ty plugin so that `DocsPage` can concentrate on rendering data
demos now load scripts and styles with link and script tags, using relative URLs, as one might expect.
🦋 Changeset detectedLatest commit: dfb9061 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
🏮 Lighthouse report for the changes in this PR:🟠 🟢 🟢 🟠 ⚪️ https://deploy-preview-2059--patternfly-elements.netlify.app/kitchen-sink/🔦 Lighthouse Report for https://deploy-preview-2059--patternfly-elements.netlify.app/kitchen-sink/
💥 Assertion Failures
🟢 🔴 🟢 🟢 ⚪️ Styles🔦 Lighthouse Report for Styles
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Accordion🔦 Lighthouse Report for Accordion
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Autocomplete🔦 Lighthouse Report for Autocomplete
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Avatar🔦 Lighthouse Report for Avatar
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Badge🔦 Lighthouse Report for Badge
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Band🔦 Lighthouse Report for Band
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Button🔦 Lighthouse Report for Button
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Card🔦 Lighthouse Report for Card
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Clipboard🔦 Lighthouse Report for Clipboard
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Codeblock🔦 Lighthouse Report for Codeblock
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Collapse🔦 Lighthouse Report for Collapse
💥 Assertion Failures
🟢 🟢 🟢 🟠 ⚪️ Cta🔦 Lighthouse Report for Cta
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Datetime🔦 Lighthouse Report for Datetime
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Dropdown🔦 Lighthouse Report for Dropdown
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Health Index🔦 Lighthouse Report for Health Index
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Icon🔦 Lighthouse Report for Icon
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Icon Panel🔦 Lighthouse Report for Icon Panel
💥 Assertion Failures
🟠 🟢 🟢 🟢 ⚪️ Jump Links🔦 Lighthouse Report for Jump Links
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Label🔦 Lighthouse Report for Label
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Markdown🔦 Lighthouse Report for Markdown
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Modal🔦 Lighthouse Report for Modal
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Number🔦 Lighthouse Report for Number
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Page Status🔦 Lighthouse Report for Page Status
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Primary Detail🔦 Lighthouse Report for Primary Detail
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Progress Indicator🔦 Lighthouse Report for Progress Indicator
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Progress Steps🔦 Lighthouse Report for Progress Steps
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Readtime🔦 Lighthouse Report for Readtime
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Select🔦 Lighthouse Report for Select
💥 Assertion Failures
🟢 🟠 🟢 🟢 ⚪️ Tabs🔦 Lighthouse Report for Tabs
💥 Assertion Failures
🟢 🟢 🟢 🟢 ⚪️ Toast🔦 Lighthouse Report for Toast
💥 Assertion Failures
|
@zeroedin ok please approve if you think it's ready to roll |
@bennypowers - Made a small change to the PR with an update to fix |
Nice catch @brianferry. If you're GTG please drop an approval and we'll get this show on the road |
@brianferry and I found some additional issues When you load this PR's changes downstream in the RHDS repo: In Firefox
for
Safari is similar to firefox for
rh-dialog
Chrome seems to fail on the same error on
Similar resolution errors were observed when looking at the Patternfly demos through Chrome loading
Safari loading
Firefox loading
|
A separate issue appears to be no demo pages being generated for footer at all:
|
Looks like a fix for the first issue might be moving <script type="importmap">{{ importMap | dump | safe }}</script>above {%- for href in preloads -%} in docs/components/demo.html |
This definitely looks to fix the errors for PFE demos. Looks like the observed.js resolve issue is a separate issue.
|
Very helpful notes, thanks
I'm going to work on
then i'll push those changes up and ping you for review |
b9f7391
to
94520d4
Compare
ok these changes give us:
Once this is in place, we can use the demo links on ux-dot as part of the IA to display livecoding playgrounds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested it locally and everything looked good
What I Did
/components/jazz-hands
urls