Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unminify css when bundling #2710

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Mar 20, 2024

What I did

  1. unminify the shadow css when bundling

Testing Instructions

  1. on the DP chip group demo page, chip close buttons should be vertically centered, as normal. If this PR is broken, they will appear below the vertical center line.

Screenshot 2024-03-20 at 8 00 43

Copy link

changeset-bot bot commented Mar 20, 2024

⚠️ No Changeset found

Latest commit: e78ab0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 7895501
😎 Deploy Preview https://deploy-preview-2710--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 20, 2024
@github-actions github-actions bot added the doc label Mar 20, 2024
@github-actions github-actions bot added the tools Development and build tools label Mar 20, 2024
@bennypowers bennypowers enabled auto-merge (squash) March 20, 2024 09:05
@bennypowers bennypowers requested a review from zeroedin March 20, 2024 10:06
Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird issue when docs/demo's build, pf-chip.d.js is included in import map, instead of pf-chip.js

image

demo/pf-chip.html

<script type="module">
  import '@patternfly/elements/pf-chip/pf-chip.js';
</script>

ERROR: Uncaught TypeError: Failed to resolve module specifier "@patternfly/elements/pf-chip/pf-chip.js". Relative references must start with either "/", "./", or "../".

Appears to be happening to all elements now on this PR.

Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lunar gravity, tugging moons

@bennypowers bennypowers merged commit 7f634f8 into main Mar 21, 2024
15 checks passed
@bennypowers bennypowers deleted the docs/bundle-without-breaking-css branch March 21, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed doc ready to merge tools Development and build tools
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants