-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cards): Updates images for v6. #4508
base: main
Are you sure you want to change the base?
Conversation
@edonehoo I've updated the image in the "Border treatments" section, but the content needs to be tweaked. Short term fix: change the section to be "Styling" and call out the difference between primary and secondary cards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there may (?) have been a chart in your second image that was in a different frame or something!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops! fixing it now
docs(cards): Moves and updates card variations.
...ntation-site/patternfly-docs/content/design-guidelines/components/card/img/card-withlink.svg
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment about a small caption thing that could be tweaked, but these look great!
Closes #4275