Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cards): Updates images for v6. #4508

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bekah-stephens
Copy link

Closes #4275

@bekah-stephens
Copy link
Author

@edonehoo I've updated the image in the "Border treatments" section, but the content needs to be tweaked.

Short term fix: change the section to be "Styling" and call out the difference between primary and secondary cards.
Longer term fix: look at moving this section within Variations, rather than Usage where it is now.

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 24, 2025

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there may (?) have been a chart in your second image that was in a different frame or something!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops! fixing it now

Copy link
Collaborator

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about a small caption thing that could be tweaked, but these look great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guideline updates: Cards & Tiles
3 participants