Assorted fixes #1721
Merged
Assorted fixes #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialog was being shown from within MW2's showEvent, but that event is called just *before* the window is visible, hence why the dialog wasn't actually modal.
The enable/disable code was written under the assumption that undo/redo could only be triggered from the menu, but did not take keyboard shortcuts or the recently added toolbar into account.
MrStevns
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a collection of various unrelated fixes and enhancements. I don’t think any of them have been (formally) reported. Here’s a list of the issues:
I also took another look at the setlocale() workaround for #940 because I always felt like there must be a better solution. And I was right! Not only that, but the Qt devs already implemented it some time ago in 5.14 – because as it turns out, this was a bug in Qt all along. I’ve verified that the bug is indeed gone in current Qt versions and updated the code accordingly. I also updated it to use the C locale instead of US English (because the latter might not always be available) and moved the code so that it is run after QCoreApplication has been initialised, as recommended in the documentation.