Fix brush cursor size with canvas rotation #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scribblemaniac
added
Bug
Canvas
UI
|
This works perfectly, even when the view is flipped! Thank you so so much! 😄 |
MrStevns
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rotating the canvas, the brush cursor displays the wrong size. This was because mapRect is used, which will expand the size of a QRect to fit the bounding box of a rotated rectangle. This fix manually applies the view transform to the rect by translating the rect (based on the view translation, scale and rotation) and scaling the rect size without actually rotating the rect.
Fixes #1868.