Fixing PIW Movement #192
Merged
Fixing PIW Movement #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per/drone-swarm-search into renato-feature-piw-movement
…per/drone-swarm-search into renato-feature-piw-movement
…. The noised movement vector implementation might be removed.
…into renato-feature-piw-movement
renatex333
requested review from
JorasOliveira,
Pedro2712 and
RicardoRibeiroRodrigues
|
opiniao controversa talvez, mas se enquanto esse PR for um retrocesso na movimentação, acho que nao vale o merge |
…y matrix and piw movement. Now they are both in sync, trying to achieve a piw that can, eventually, move in front of the probability matrix, generating new scenarios for the agent to learn.
Concordo! Estou trabalhando nas implementações sugeridas pelo professor Ayres. Creio que mais algumas iterações no design e etapas de validação já serão suficientes para deixar tudo pronto para produção. Por enquanto, vamos segurar o PR. |
…ee that both, the person and the matrix, have their calculations done coherently.
…son and the probability matrix, making them move accordingly with their speeds. This way, there is no need for a time step barrier to be reached.
|
Agora está tudo funcionando como esperado e sem bugs. Assim que obtiver a validação do professor, confirmo aqui. |
Pedro2712
approved these changes
Apr 12, 2024
…ollowing suggestions received.
Fix exchanged x,y in person update_position + increment position logic
RicardoRibeiroRodrigues
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix on env.py: now each piw moves based on its own "movement map", which was not being done previously.
Feature on person.py: implemented a new way of modeling the piw movement, based on the probability matrix, but not following the highest probability. It involves picking a new position randomly (random walk or drunkard's walk), wheighted by the probabilities of a 3x3 snip of the probability matrix cells that contains the piw at the center.