Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty patch #37

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Handle empty patch #37

merged 1 commit into from
Jun 14, 2019

Conversation

dtaniwaki
Copy link
Contributor

The change in #25 only allow to create empty commits and diff but the ghost commits are not actually usable by git ghost pull because of the following error.

error: unrecognized input

@dtaniwaki
Handle empty patch

Verified

This commit was signed with the committer’s verified signature.
thisiskeithb Keith Bennett
GPG key ID: 563DA16B756772CE
Verified
Learn about vigilant mode
81380b6
@dtaniwaki dtaniwaki requested a review from everpeace June 13, 2019 06:06
@dtaniwaki dtaniwaki mentioned this pull request Jun 13, 2019
Merged
everpeace
everpeace approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dtaniwaki dtaniwaki merged commit ba7c3b1 into pfnet-research:master Jun 14, 2019
@dtaniwaki dtaniwaki deleted the handle-empty-patch branch June 14, 2019 04:54
@dtaniwaki dtaniwaki mentioned this pull request Jun 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everpeace everpeace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtaniwaki @everpeace