Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os.Getwd instead of os.Getenv("PWD"). #40

Merged
merged 3 commits into from
Jun 17, 2019

Conversation

oda
Copy link

@oda oda commented Jun 14, 2019

$PWD is only available for UNIX like OS, and os.Getwd returns $PWD as far as
$PWD and "." are the same directory. This makes it possible to call git ghost
from other programs such as gitpython.

$PWD is only available for UNIX like OS, and os.Getwd returns $PWD as far as
$PWD and "." are the same directory. This makes it possible to call git ghost
from other programs such as gitpython.
@dtaniwaki dtaniwaki self-requested a review June 14, 2019 08:15
@dtaniwaki
Copy link
Contributor

Thank you for the pull request! I think your suggestion makes sense.

Would you also update the help message?

RootCmd.PersistentFlags().StringVar(&globalOpts.srcDir, "src-dir", "", "source directory which you create ghost from (default to PWD env)")

Maybe, something like (default to the current directory).

@oda
Copy link
Author

oda commented Jun 15, 2019

I addressed your comments. Thanks.

Copy link
Contributor

@dtaniwaki dtaniwaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dtaniwaki dtaniwaki merged commit e2a30bf into pfnet-research:master Jun 17, 2019
@dtaniwaki dtaniwaki mentioned this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants