ext/bcmath: Fixed pointer subtraction for scale #17986
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, do you have a test? |
|
@nielsdos |
|
Since this is the code for when In the following code, However, since only values up to scale 10 are used for comparison, there will be no erroneous results. |
nielsdos
approved these changes
Mar 7, 2025
ext/bcmath/libbcmath/src/str2num.c
Outdated
| @@ -180,7 +180,7 @@ bool bc_str2num(bc_num *num, const char *str, const char *end, size_t scale, siz | |||
| */ | |||
| if (str_scale > 0) { | |||
| const char *fractional_new_end = bc_skip_zero_reverse(fractional_end, fractional_ptr); | |||
| str_scale -= fractional_new_end - fractional_end; | |||
| str_scale -= fractional_end - fractional_new_end; // fractional_end >= fractional_new_end | |||
There was a problem hiding this comment.
Please use c-style comments, i.e. /* */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.