Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stubs of DateTimeZone->getTransitions #17992

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marc-mabe
Copy link
Contributor

The default value of timestamp_end is INT32_MAX and not ZEND_LONG_MAX.

Additionally, changing the default to ZEND_LONG_MAX would result in an OOM error on calling the function without params.

The default value of `timestamp_end` is INT32_MAX and not ZEND_LONG_MAX
Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants