ext/gd: calls with array types check strengthening. #18005
+165
−15
Next
Next commit
ext/gd: calls with array types check strengthening.
commit 3233235a8a50b671410f15a19f168f7d1513734f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| --TEST-- | ||
| GH-18005: imagesetstyle, imagefilter, imagecrop array values type checks | ||
| --EXTENSIONS-- | ||
| gd | ||
| --SKIPIF-- | ||
| <?php | ||
| if (PHP_INT_SIZE != 8) die('skip this test is for 64bit platforms only'); | ||
| ?> | ||
| --FILE-- | ||
| <?php | ||
| class A {} | ||
| $img = imagecreatetruecolor(1, 1); | ||
| try { | ||
| imagesetstyle($img, [0, new A()]); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagesetstyle($img, [0, PHP_INT_MIN]); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagefilter($img, IMG_FILTER_SCATTER, 0, 0, array(new A())); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagefilter($img, IMG_FILTER_SCATTER, 0, 0, array(-1)); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagecrop($img, array("x" => PHP_INT_MIN, "y" => 0, "width" => 0, "height" => 0)); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagecrop($img, array("x" => 0, "y" => PHP_INT_MIN, "width" => 0, "height" => 0)); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagecrop($img, array("x" => 0, "y" => 0, "width" => PHP_INT_MAX, "height" => 0)); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagecrop($img, array("x" => 0, "y" => 0, "width" => 0, "height" => PHP_INT_MAX)); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
|
|
||
| try { | ||
| imagecrop($img, array("x" => new A(), "y" => 0, "width" => 0, "height" => 0)); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagecrop($img, array("x" => 0, "y" => new A(), "width" => 0, "height" => 0)); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagecrop($img, array("x" => 0, "y" => 0, "width" => new A(), "height" => 0)); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| try { | ||
| imagecrop($img, array("x" => 0, "y" => 0, "width" => 0, "height" => new A())); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage(); | ||
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| imagesetstyle(): Argument #2 ($style) value must be of type int, A given | ||
| imagesetstyle(): Argument #2 ($style) value must be between %i and %d | ||
| imagefilter(): Argument #5 value must be of type int, A given | ||
| imagefilter(): Argument #5 value must be between 0 and 2147483647 | ||
| imagecrop(): Argument #2 ($rectangle) "x" key must be between %i and %d | ||
| imagecrop(): Argument #2 ($rectangle) "y" key must be between %i and %d | ||
| imagecrop(): Argument #2 ($rectangle) "width" key must be between %i and %d | ||
| imagecrop(): Argument #2 ($rectangle) "height" key must be between %i and %d | ||
| imagecrop(): Argument #2 ($rectangle) "x" key must be of type int, A given | ||
| imagecrop(): Argument #2 ($rectangle) "y" key must be of type int, A given | ||
| imagecrop(): Argument #2 ($rectangle) "width" key must be of type int, A given | ||
| imagecrop(): Argument #2 ($rectangle) "height" key must be of type int, A given |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symbols starting with
_are reserved in C, so please avoid this.