Fix GH-17951: Addition of max_memory_limit INI #18011
Open
+209
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Mar 10, 2025
iluuu1994
reviewed
Mar 10, 2025
|
Looks good in general though. 👍 |
iluuu1994
approved these changes
Mar 11, 2025
main/main.c
Outdated
| @@ -317,11 +317,39 @@ static PHP_INI_MH(OnSetSerializePrecision) | |||
| static PHP_INI_MH(OnChangeMemoryLimit) | |||
| { | |||
| size_t value; | |||
|
|
|||
There was a problem hiding this comment.
Nit: Please avoid unrelated whitespace changes.
main/main.c
Outdated
| @@ -332,7 +360,30 @@ static PHP_INI_MH(OnChangeMemoryLimit) | |||
| return FAILURE; | |||
| } | |||
| } | |||
|
|
|||
main/main.c
Outdated
| } | ||
| /* }}} */ | ||
|
|
||
| /* {{{ PHP_INI_MH */ |
There was a problem hiding this comment.
We decided to drop vim comments for new code
|
@frederikpyt Feel free to ping me again ~2 weeks after you've sent the e-mail to the internals mailing list. If there are no objections, this may be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new INI
max_memory_limitwhich acts as a cap on how much you can raisememory_limitusingini_set()during runtime.Perhaps see: #17951