ext/mysqlnd: fix passing wrong parameter after a893a49

[manuelm]

Stumbled upon this. Looks like a wrong replacement in a893a49.

[kamil-tekiela]

Good catch! Is there any way to add a test for this?

[kamil-tekiela]

It should also be fixed in earlier versions I presume.

[manuelm]

Good catch! Is there any way to add a test for this?

I'll take a look.

It should also be fixed in earlier versions I presume.

yeah. forgot about upmerging. PHP-8.3 right?

[manuelm]

Good catch! Is there any way to add a test for this?

Unfortunately these member variables aren't even used in any internal code. So testing is not possible. Maybe these are some left overs from the reconnect feature?

[kamil-tekiela]

I don't think we ever had a reconnect feature in mysqlnd. It could be a left-over from some old feature, which sounds plausible given that there were no bug reports for this yet. I think this needs more investigation. If it's not used, then this piece of code should be removed.

[manuelm]

So I looked back in the history and these variables are in since the introduction of st_mysqlnd_connection back in 2007. However even then there was no actual use of the stored information.