Syntax collision with Type Ascription

[hoodie]

The current nightly of rustc merged Type Ascription, which seems to collide with the format syntax of prettytable-rs.

[phsym]

Type Ascription indeed conflicts with the style syntax in macros.
For example in cell.rs :

macro_rules! cell {
    () => ($crate::cell::Cell::default());
    ($value:expr) => ($crate::cell::Cell::new(&$value.to_string()));
    ($style:ident : $value:expr) => (cell!($value).style_spec(stringify!($style)));
}

($style:ident : $value:expr) is in conflict.

Do you think this is expected and I should change the macro syntax, or should I report this as an
issue to rust team ?

[hoodie]

I have no idea. Though I suppose this might affect several crates. This issue already shows up as a mention in the linked RFC issue.

[phsym]

I also think it will affect several crates. Maybe I should wait a bit and see, or do you need an urgent fix ?

[hoodie]

Nope no biggy. I just wanted to mention this to you. Worst case: you have to change your api. Best case: the compiler learns to distinguish.
Let's see what happens.

[phsym]

By the way @hoodie, thank you for mentionning this issue. I don't play that much with nightly rust for now.

[miketang84]

any new info？

[hoodie]

I would consider preemptively changing the macro syntax of this crate. This could still be a valid 0.6.0 release.

[phsym]

That's also what I was thinking about. This won't be a big code change.

[phsym]

FYI, the crate has been fixed for nightly issue. I changed the macro syntax, and it's now available on crates.io in v0.6.0

[hoodie]

👍
man do I wish github would just let me like your comment

[phsym]

😄 A thumb is all you need

[miketang84]

👍