site_close issue

[Marc-pi]

in var/config/engine.php
setting to 1 the site_close value closes completely the access the site, even the admin site

in lib/Pi/Application/Boostrap/Resource/Permission.php line 58
the Permission class has in the checkAction method with this test

// Deny all access to front for close/maintenance
if (Pi::config('site_close')) {
$this->denyAccess($e);
return;
}

that makes use of the denyAccess method
protected function denyAccess(MvcEvent $e)
{
$statusCode = Pi::service('user')->getUser()->isGuest()
? 401 : 403;
$e->getResponse()->setStatusCode($statusCode);
$e->setError(true);
}

=> should not block the access to admin.
=> would be nice to implement a dedicated template also

[Marc-pi]

thanks for the changes, there is a little typo still

in var/config/application.admin.php
please uncomment line 29
'check_close' => false,

and change comment
// Whether to check site_close for maintenance, default as true
to
// Whether to check site_close for maintenance, default as false

to make it work properly by default (only admin access when site is closed)

[Marc-pi]

thanks for the uncomment, don't forget to change the comment, so i can close this issue

[Marc-pi]

@taiwen can you change the comment line

// Whether to check site_close for maintenance, default as true
to
// Whether to check site_close for maintenance, default as false

to have the proper default value indication (only admin access when site is closed)
so i can close afterwards this ticket
thanks

[taiwen]

What default as true means is that if check_close is not specified, it will be treated as true.
So, the existent comment is not wrong.

[Marc-pi]

ok, i learned something new again today about Pi ;-)