Fix deleting sub objects of locked folders if folder is selected #848
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattamon
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
PR Overview
This PR fixes an issue whereby sub objects of locked folders are incorrectly deleted when the folder itself is selected. Key changes include the filtering of deleted items to remove those that are not allowed and updating the logic that determines if any deletable items remain.
Reviewed Changes
| File | Description |
|---|---|
| public/js/pimcore/elementservice.js | Added filtering to remove items not allowed to be deleted; redundant filtering remains when checking for deletable items. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
public/js/pimcore/elementservice.js:56
- Since res.itemResults has already been filtered to include only allowed items on line 54, consider replacing this redundant filter with a direct length check, e.g., hasDeleteable = res.itemResults.length > 0.
hasDeleteable = res.itemResults.filter(function (result) {
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
martineiber
approved these changes
Mar 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #847