Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony Flex: added symfony.lock file to optionally support Flex #204

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

brusch
Copy link
Member

@brusch brusch commented Oct 30, 2024

Pimcore is shipped with quite some default configurations for Symfony bundles (not only Symfony config, but also docker-compose.yaml ...).
Adding this symfony.lock files allows the developer to optionally use symfony/flex with a new Pimcore project, without breaking the installation by running composer require symfony/flex because the lock file includes already all the packages that are used by stock Pimcore and therefore all the additional recipes are not getting executes for those packages.

Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattamon mattamon added this to the 2024.4.0 milestone Nov 8, 2024
@mattamon mattamon merged commit 18aca11 into 2024.x Nov 22, 2024
3 checks passed
@mattamon mattamon deleted the symfony_flex branch November 22, 2024 07:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants