Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Fix broken link in shard-merge-best-practices.md and addd a missing section (#900) #901

Merged
merged 4 commits into from
May 23, 2022
Merged

Fix broken link in shard-merge-best-practices.md and addd a missing section (#900) #901

merged 4 commits into from
May 23, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #900

First-time contributors' checklist

What is changed, added, or deleted? (Required)

  1. Fix broken link in shard-merge-best-practices.md reported by Broken Link Detected #898.
  2. Fix a section that is missing in translation from zh: add detailed checks and steps for shard-merge scenario #698 to update toc.md, shard-merge.md, add incremental data migration document #748

Which DM version(s) do your changes apply to? (Required)

Since December 23, 2021, the TiDB DM documentation in the master branch has been merged to TiDB documentation by #8042 and #7317. To create a PR for TiDB DM versions later than v5.3, either go to TiDB English documentation repository or Chinese documentation repository.

  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added area/best-practices Adds or updates TiDB best practices. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug-fix Fixes typos or wrong format. type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR. labels May 23, 2022
@ti-chi-bot ti-chi-bot requested a review from shichun-0415 May 23, 2022 07:21
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9a389f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit 469938f into pingcap:release-2.0 May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/best-practices Adds or updates TiDB best practices. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Fixes typos or wrong format. type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants