server: fix potential goroutine leak when kill connection #13051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
changed the title
SunRunAway
commented
Oct 31, 2019
| if err != nil { | ||
| metrics.ExecuteErrorCounter.WithLabelValues(metrics.ExecuteErrorToLabel(err)).Inc() | ||
| return err | ||
| } | ||
| status := atomic.LoadInt32(&cc.status) | ||
| if rs != nil && (status == connStatusShutdown || status == connStatusWaitShutdown) { | ||
| killConn(cc) |
There was a problem hiding this comment.
Here it need not to killConn again
|
@lysu I've updated test, now it can be covered by |
|
LGTM |
tiancaiamao
approved these changes
Nov 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #13051 +/- ##
================================================
+ Coverage 80.0413% 80.0524% +0.0111%
================================================
Files 468 468
Lines 109852 109828 -24
================================================
- Hits 87927 87920 -7
+ Misses 15170 15161 -9
+ Partials 6755 6747 -8 |
SunRunAway
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 12997 |
|
/run-all-tests |
|
/run-all-tests |
|
@SunRunAway merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
SunRunAway
added a commit
to SunRunAway/tidb
that referenced
this pull request
Nov 7, 2019
SunRunAway
added a commit
to SunRunAway/tidb
that referenced
this pull request
Nov 7, 2019
This was referenced Nov 7, 2019
SunRunAway
added a commit
to SunRunAway/tidb
that referenced
this pull request
Nov 7, 2019
sre-bot
pushed a commit
that referenced
this pull request
Nov 8, 2019
sre-bot
pushed a commit
that referenced
this pull request
Nov 8, 2019
sre-bot
pushed a commit
that referenced
this pull request
Nov 8, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #13050
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note