Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session/statistics: discard feedbacks from delete / update (#17452) #17841

Merged
merged 2 commits into from
Jun 28, 2020
Merged

session/statistics: discard feedbacks from delete / update (#17452) #17841

merged 2 commits into from
Jun 28, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 8, 2020

cherry-pick #17452 to release-3.0

What problem does this PR solve?

Issue Number: close #17438

Problem Summary:

Feedbacks from update, delete may be invalid.

What is changed and how it works?

What's Changed:

Discard those feedbacks.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Discard feedbacks generated from delete / update statements.

@eurekaka @sre-bot
cherry pick pingcap#17452 to release-3.0
e2ac8bc 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 8, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
@sre-bot sre-bot requested review from XuHuaiyu and zz-jason June 8, 2020 06:38
@sre-bot sre-bot added this to the v3.0.16 milestone Jun 8, 2020
zz-jason
zz-jason reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2020
@zz-jason zz-jason linked an issue Jun 11, 2020 that may be closed by this pull request
discard feedbacks from delete / update statements #17438
Closed
XuHuaiyu
XuHuaiyu approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2020
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 17308
  • 17496
  • 17499
  • 17583
  • 17710
  • 17715

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit b5ae1e7 into pingcap:release-3.0 Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees

@eurekaka eurekaka

Labels
component/statistics epic/query-feedback-GA sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.16
Development

Successfully merging this pull request may close these issues.

discard feedbacks from delete / update statements
7 participants
@sre-bot @ti-srebot @zz-jason @XuHuaiyu @SunRunAway @eurekaka @qw4990