Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller: fix potential stuck #12080

Merged
merged 1 commit into from
Mar 6, 2025
Merged

puller: fix potential stuck #12080

merged 1 commit into from
Mar 6, 2025

Conversation

lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented Mar 6, 2025

What problem does this PR solve?

Issue Number: close #12081

What is changed and how it works?

Add cdc version in deregister request header.
The reason why this is needed is described in the issue.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 6, 2025
@lidezhu lidezhu requested review from hicqu and asddongmen March 6, 2025 06:07
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.1233%. Comparing base (4d70424) to head (0630d60).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc 59.3624% <0.0000%> (+0.0122%) ⬆️
dm 50.1247% <ø> (-0.0212%) ⬇️
engine 53.2505% <ø> (+0.0282%) ⬆️
Flag Coverage Δ
unit 55.1233% <0.0000%> (+0.0017%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #12080        +/-   ##
================================================
+ Coverage   55.1216%   55.1233%   +0.0017%     
================================================
  Files          1030       1030                
  Lines        143196     143197         +1     
================================================
+ Hits          78932      78935         +3     
+ Misses        58466      58465         -1     
+ Partials       5798       5797         -1     
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 6, 2025
@lidezhu lidezhu added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Mar 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-06 06:46:21.69833721 +0000 UTC m=+510494.827256954: ☑️ agreed by hicqu.
  • 2025-03-06 06:59:30.098235977 +0000 UTC m=+511283.227155721: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot merged commit 6973b6b into master Mar 6, 2025
27 of 28 checks passed
@ti-chi-bot ti-chi-bot bot deleted the ldz/fix-potential-stuck branch March 6, 2025 07:04
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #12082.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

puller may got stuck in some cases
4 participants