Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processor: fix addTable waiting for done (#1332) #1363

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 27, 2021

cherry-pick #1332 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In ticdc repo:
git pr https://github.com/pingcap/ticdc/pull/1363

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/ticdc.git pr/1363:release-4.0-2d0353221a49

What problem does this PR solve?

#1330

What is changed and how it works?

  • Let processor wait for the table checkpoint to catch up with the global checkpoint, before marking the operation as done.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix potential data loss if a processor crashes when starting up a table.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added type/bugfix This PR fixes a bug. status/ptal Could you please take a look? type/4.0-cherry-pick labels Jan 27, 2021
@ti-srebot ti-srebot added this to the v4.0.11 milestone Jan 27, 2021
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
@amyangfei amyangfei merged commit d37384f into pingcap:release-4.0 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants