Masonry: Add integration test for dynamic heights v2 and masonry testing page #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
JosAnGoCa
changed the title
JosAnGoCa
changed the title
JosAnGoCa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create a new page for the integration tests that contains to multi column items with a column span of 3, also created integration test for dynamic heights v2 that use this page
What changed?
A new page has been created to support integration tests, featuring multi-column items configured with a column span of 3.
This page is designed to test not only dynamic height adjustments but also the positioning of multi-column items and the handling of dynamic batch sizing. The access is via the url paramter
fixedThreeColItems=trueA new test file has been introduced to rigorously test the Dynamic Heights V2 algorithm. These tests cover a variety of use cases, including: Pushing a multi-column item, Double resizing, Partial pushing of a column. This comprehensive testing ensures that the algorithm handles different scenarios effectively and maintains stable performance.
Why?
The purpose of these changes is to comprehensively verify the Dynamic Heights V2 algorithm's performance and stability in a visually complex environment. By using a page that simulates a variety of layout scenarios and content variations, these tests offer a robust evaluation of algorithmic behavior across numerous use cases.
Checklist