Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont include videoDepacketizer in VP1Packet #296

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

jech
Copy link
Member

@jech jech commented Feb 27, 2025

Now that we have separated the Packet/Depacketizer roles for
the AV1 codec, there is no need to include the videoDepacketizer
mixin in AV1Packet.

Related to #291

Now that we have separated the Packet/Depacketizer roles for
the AV1 codec, there is no need to include the videoDepacketizer
mixin in AV1Packet.
@jech
Copy link
Member Author

jech commented Feb 27, 2025

CC @JoeTurki

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (48e175c) to head (061df8a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   85.89%   85.99%   +0.10%     
==========================================
  Files          26       26              
  Lines        2913     2913              
==========================================
+ Hits         2502     2505       +3     
+ Misses        352      350       -2     
+ Partials       59       58       -1     
Flag Coverage Δ
go 85.99% <ø> (+0.10%) ⬆️
wasm 85.41% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jech thank you it's getting deprecated anyway with the payloader rewrite #295 probably removed by the next major release as it has no use for now, And i didn't want to remove it or changed in cause someone is using it.

@JoeTurki
Copy link
Member

I'll make a proper av1 bitstream and frame reader, and a parser for some OBUs like sq header, but this would fit more in webrtc,

@jech jech merged commit 061df8a into pion:master Feb 27, 2025
14 checks passed
@jech
Copy link
Member Author

jech commented Feb 27, 2025

Let's move h.264 to the same style, so we can remove state from H264Packet and move it into H264Depacketizer. But first, I need to move Galene to Pion v4 (I've been waiting on pion/webrtc#2994 and on pion/webrtc#3003, but I guess they won't happen in time).

@JoeTurki
Copy link
Member

JoeTurki commented Feb 27, 2025

@jech I'm going to start with H264 enhancements just after AV1, and planning to fix all the reported bugs, and optimize it more, bring it up to the spec more, and will make a H264Depacketizer too :)

@JoeTurki
Copy link
Member

@jech Sean added the TWCC to the v4.1.0 milestone I'll help with this after I finish my todo list for this milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants