-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont include videoDepacketizer in VP1Packet #296
Conversation
Now that we have separated the Packet/Depacketizer roles for the AV1 codec, there is no need to include the videoDepacketizer mixin in AV1Packet.
CC @JoeTurki |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 85.89% 85.99% +0.10%
==========================================
Files 26 26
Lines 2913 2913
==========================================
+ Hits 2502 2505 +3
+ Misses 352 350 -2
+ Partials 59 58 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a proper av1 bitstream and frame reader, and a parser for some OBUs like sq header, but this would fit more in webrtc, |
Let's move h.264 to the same style, so we can remove state from H264Packet and move it into H264Depacketizer. But first, I need to move Galene to Pion v4 (I've been waiting on pion/webrtc#2994 and on pion/webrtc#3003, but I guess they won't happen in time). |
@jech I'm going to start with H264 enhancements just after AV1, and planning to fix all the reported bugs, and optimize it more, bring it up to the spec more, and will make a H264Depacketizer too :) |
@jech Sean added the TWCC to the v4.1.0 milestone I'll help with this after I finish my todo list for this milestone. |
Now that we have separated the Packet/Depacketizer roles for
the AV1 codec, there is no need to include the videoDepacketizer
mixin in AV1Packet.
Related to #291