Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hook EditorAction::modifyDecisionOptions needed for future RQC plugin #2439

Merged
merged 2 commits into from
Sep 14, 2019

Conversation

prechelt
Copy link

The (currently half-complete) Review Quality Collector generic plugin needs to hook into this operation.

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2019

CLA assistant check
All committers have signed the CLA.

@prechelt
Copy link
Author

@asmecher wrote in the forum not to worry about this random test failure. So I'll sit back and assume I'll hear about this PR eventually.

@asmecher
Copy link
Member

asmecher commented Aug 1, 2019

@prechelt, a couple of quick requests:

  • Could you initialize the $result variable at the head of the function (e.g. to null)?
  • I know this is already missing :) but please add a @return self-documentation to the function head.

Thanks!

@asmecher asmecher merged commit 8a1fc9c into pkp:stable-3_1_2 Sep 14, 2019
asmecher added a commit to pkp/pkp-lib that referenced this pull request Sep 14, 2019
@asmecher
Copy link
Member

Thanks, @prechelt! Merged and ported forward to master.

@prechelt prechelt deleted the modifydecisionoptionshook branch August 30, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants