Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42 get rid of MAX_TOPIC_SUBSCRIPTION_LIST_SIZE entirely #47

Closed
wants to merge 1 commit into from

Conversation

StephanMeijer
Copy link
Contributor

@StephanMeijer StephanMeijer commented Mar 15, 2020

Because the inability to set more than 10 subscriptions, even with the workaround provided in #42.

Only tested EspMQTTClient::subscribe.

@StephanMeijer
Copy link
Contributor Author

CC @MoosHam :)

@plapointe6
Copy link
Owner

Thanks for the contribution 👍. It's a great idea. Since I changed many things in the code that is in a testing phase (dev branch), it will be to difficult to merge the dev branch to master if I apply your changes to master. I will copy them manually to the dev branch. Regards.

plapointe6 pushed a commit that referenced this pull request Sep 3, 2020
@plapointe6
Copy link
Owner

Merged into master, will be releashed soon into v1.9

@plapointe6 plapointe6 closed this Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants