-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable test due to #5641 #5647
Conversation
7759896
to
41cf3f0
Compare
Codecov Report
@@ Coverage Diff @@
## stable-1.13 #5647 +/- ##
============================================
Coverage 74.25% 74.26%
============================================
Files 145 145
Lines 22131 22131
Branches 3704 3705 +1
============================================
+ Hits 16433 16435 +2
+ Misses 5698 5696 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
src/test/ex_libpmem2/TESTS.py
line 80 at r1 (raw file):
Nitpick.
XXX Disable the test execution under pmemcheck with g.PAGE until fixed. URL
src/test/ex_libpmem2/TESTS.py
line 81 at r1 (raw file):
Nitpick.
to be removed when fixed
src/test/ex_libpmem2/TESTS.py
line 94 at r1 (raw file):
# XXX see TEST5 above @t.require_valgrind_disabled('pmemcheck') class TEST501(TEST5): # to be removed when fix available
Are you sure you do not inherit all the decorators from the parent class? 🤔
965c6cf
to
0fa5389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @janekmi)
src/test/ex_libpmem2/TESTS.py
line 94 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Are you sure you do not inherit all the decorators from the parent class? 🤔
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
Disable test ex_libpmem2/TEST5 for pmemcheck/page configuration until a fix is provided for #5641.
Signed-off-by: Tomasz Gromadzki tomasz.gromadzki@intel.com
This change is