Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use >>.grep if .grep is enough #4

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Don't use >>.grep if .grep is enough #4

merged 1 commit into from
Mar 11, 2021

Conversation

lizmat
Copy link
Contributor

@lizmat lizmat commented Mar 11, 2021

The use of >>.grep in combination with stringification is something that feels strange. In any case, somehow the recent speedup of >>. (aka nodemap) something subtly changed so that that expression generates a Seq with a lot of empty Seqs in them, each of which stringifies to a space, and thus breaks the test.

Since I don't see a need for the >>. there, I'd thought it safe to remove.

The use of `>>.grep` in combination with stringification is something that feels strange.  In any case, somehow the recent speedup of `>>.` (aka `nodemap`) something subtly changed so that that expression generates a `Seq` with a lot of empty `Seq`s in them, each of which stringifies to a space, and thus breaks the test.

Since I don't see a need for the `>>.` there, I'd thought it safe to remove.
@lizmat lizmat mentioned this pull request Mar 11, 2021
2 tasks
@pmqs
Copy link
Owner

pmqs commented Mar 11, 2021

Thanks @lizmat !

@pmqs pmqs merged commit 42b7504 into pmqs:master Mar 11, 2021
@Altai-man
Copy link

Hi, @pmqs!

In another run of testing I see there is still an upload on CPAN which does not include this fix:

===> Found: Archive::SimpleZip:ver<0.4.0> [via Zef::Repository::Ecosystems]
===> Fetching [OK]: Archive::SimpleZip:ver<0.4.0> to /home/vrurg/src/Raku/Blin/data/zef-data/tmp/1616081270.1919541.232.26626353762381/Archive-SimpleZip-0.4.0.tar.gz

Can you please do a version bump and do a CPAN upload?

@pmqs
Copy link
Owner

pmqs commented Mar 18, 2021

Hi, @pmqs!

In another run of testing I see there is still an upload on CPAN which does not include this fix:

===> Found: Archive::SimpleZip:ver<0.4.0> [via Zef::Repository::Ecosystems]
===> Fetching [OK]: Archive::SimpleZip:ver<0.4.0> to /home/vrurg/src/Raku/Blin/data/zef-data/tmp/1616081270.1919541.232.26626353762381/Archive-SimpleZip-0.4.0.tar.gz

Can you please do a version bump and do a CPAN upload?

Will do

@pmqs
Copy link
Owner

pmqs commented Mar 19, 2021

Hi @Altai-man - new version uploaded to CPAN. Ping if there are any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants