Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GIMME_V instead of the deprecated GIMME #19

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

ilmari
Copy link
Contributor

@ilmari ilmari commented Aug 23, 2022

GIMME_V has been around since perl 5.003_96, and GIMME is deprecated as of perl 5.34.

GIMME_V has been around since perl 5.003_96, and GIMME is deprecated as of perl 5.34.
@pmqs pmqs merged commit 7a7b045 into pmqs:master Aug 24, 2022
@pmqs
Copy link
Owner

pmqs commented Aug 24, 2022

Thanks

@ilmari ilmari deleted the patch-1 branch September 6, 2022 14:23
@demerphq
Copy link

demerphq commented Feb 8, 2023

Hi @pmqs, sorry to bother you, but do you think you could roll a release on this some time soon? It is blocking us marking GIMME as deprecated in core.

@demerphq
Copy link

demerphq commented Feb 8, 2023

BTW, the PR this is blocking is Perl/perl5#20139

@pmqs
Copy link
Owner

pmqs commented Feb 8, 2023

Thanks for the reminder @demerphq -- I'll sort it out.

@demerphq
Copy link

demerphq commented Feb 8, 2023

Thank you!

@pmqs
Copy link
Owner

pmqs commented Feb 9, 2023

Updates now on CPAN. Probably wait a couple of days to check that there aren't any smoke failures.

@demerphq
Copy link

demerphq commented Feb 9, 2023

Wouldn't it help testing if we synced it to blead asap? Then everyone doing automated smoke tests would also test it.

@pmqs
Copy link
Owner

pmqs commented Feb 9, 2023

probably doesn't matter that much either way.

@demerphq
Copy link

demerphq commented Feb 9, 2023

Thinking about it more, i think your original instinct was right. I'm just eager to clear away as many old PRs in the perl PR queue as possible, and getting ahead of myself. Waiting a few days is a good idea. Sorry for the noise.

@pmqs
Copy link
Owner

pmqs commented Feb 9, 2023

No worries

demerphq added a commit to Perl/perl5 that referenced this pull request Feb 10, 2023
 2.204 8 February 2023
      * Update zlib sources to zlib-1.2.13
        pmqs/Compress-Raw-Zlib#20
        eafe29c85437582d16c6bda16449ea2dea534266

      * Use GIMME_V instead of the deprecated GIMME
        pmqs/Compress-Raw-Zlib#19
        7a7b045d9d8729a6c82a78039dab5decf7e65907
atoomic pushed a commit to Perl/perl5 that referenced this pull request Feb 10, 2023
 2.204 8 February 2023
      * Update zlib sources to zlib-1.2.13
        pmqs/Compress-Raw-Zlib#20
        eafe29c85437582d16c6bda16449ea2dea534266

      * Use GIMME_V instead of the deprecated GIMME
        pmqs/Compress-Raw-Zlib#19
        7a7b045d9d8729a6c82a78039dab5decf7e65907
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Mar 24, 2023
Changelog:
==========
* Update zlib sources to zlib-1.2.13
  pmqs/Compress-Raw-Zlib#20
  eafe29c85437582d16c6bda16449ea2dea534266

* Use GIMME_V instead of the deprecated GIMME
  pmqs/Compress-Raw-Zlib#19
  7a7b045d9d8729a6c82a78039dab5decf7e65907

License-Update:
 Copyright year updated to 2023.
 zlib version updated to 1.2.13, Copyright year updated to 2022.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
pjacklam pushed a commit to pjacklam/perl5 that referenced this pull request May 20, 2023
 2.204 8 February 2023
      * Update zlib sources to zlib-1.2.13
        pmqs/Compress-Raw-Zlib#20
        eafe29c85437582d16c6bda16449ea2dea534266

      * Use GIMME_V instead of the deprecated GIMME
        pmqs/Compress-Raw-Zlib#19
        7a7b045d9d8729a6c82a78039dab5decf7e65907
pjacklam pushed a commit to pjacklam/perl5 that referenced this pull request May 20, 2023
 2.204 8 February 2023
      * Update zlib sources to zlib-1.2.13
        pmqs/Compress-Raw-Zlib#20
        eafe29c85437582d16c6bda16449ea2dea534266

      * Use GIMME_V instead of the deprecated GIMME
        pmqs/Compress-Raw-Zlib#19
        7a7b045d9d8729a6c82a78039dab5decf7e65907
khwilliamson pushed a commit to khwilliamson/perl5 that referenced this pull request Jul 10, 2023
 2.204 8 February 2023
      * Update zlib sources to zlib-1.2.13
        pmqs/Compress-Raw-Zlib#20
        eafe29c85437582d16c6bda16449ea2dea534266

      * Use GIMME_V instead of the deprecated GIMME
        pmqs/Compress-Raw-Zlib#19
        7a7b045d9d8729a6c82a78039dab5decf7e65907
daregit pushed a commit to daregit/yocto-combined that referenced this pull request May 22, 2024
Changelog:
==========
* Update zlib sources to zlib-1.2.13
  pmqs/Compress-Raw-Zlib#20
  eafe29c85437582d16c6bda16449ea2dea534266

* Use GIMME_V instead of the deprecated GIMME
  pmqs/Compress-Raw-Zlib#19
  7a7b045d9d8729a6c82a78039dab5decf7e65907

License-Update:
 Copyright year updated to 2023.
 zlib version updated to 1.2.13, Copyright year updated to 2022.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants