-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: Enable cpu-specific optimizations. #195
Conversation
76bbadc
to
949e6c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏁 12 min 39 sec 🏁
That was among the fastest test runs. 🏆
(Unfortunately there is a high variance because of the randomness in the tests, so it's hard to tell how much of a difference the optimizations make.)
Indeed. |
I'm going to wait until the mlock issues are sorted before rebasing and merging this. |
This could probably be rebased now. (Which will give us another data point. ⏱️) |
949e6c5
to
f2f75f1
Compare
Done. |
Needs to be rebased again; then it can be merged, I think. |
f2f75f1
to
1edf9bd
Compare
I'd +1 this. Should we give the |
Also: rust-lang/rust#53322 (only nightly - but will that envvar mess with clippy compilation?). |
7d39a99
to
f41b94a
Compare
This is rebased. Will merge if tests pass. |
f41b94a
to
fde2fae
Compare
SIGILL 😩 |
The dependency should always be up to date on travis. I'm not sure what the deal is. |
fde2fae
to
477697b
Compare
Added |
7e976d1
to
c55d58a
Compare
I'm going to rerun the CI check a few times just to see what happens. Do we want to keep the |
We may want to experiment with setting it to We could also use a mutex to selectively prevent the tests that use the most mlock memory from running in parallel. |
In either case, the SIGILL isn't related to |
This is off by default so that binaries can be shared.
c55d58a
to
2bcea82
Compare
This is off by default so that binaries can be shared. Enabling this
flag could improve test speed on Travis (will check).