Fix extra line insertion. #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pop-os#155, and also fixes Word::Wrap when two buffer overflowing words are next to each other.
|
This is ready for review. |
jackpot51
approved these changes
Feb 2, 2024
Imberflur
reviewed
Feb 3, 2024
Comment on lines
-1049
to
-1053
| // TODO: What if the previous span ended with whitespace and the next | ||
| // span wraps a new line? Is that possible? | ||
| // | ||
| // TODO: This comment it outdated, the current word can be a | ||
| // whitespace. |
There was a problem hiding this comment.
Why were these notes removed? AFAICT the code change doesn't affect these?
|
@jackpot51 Would you be open to cutting a new minor version of cosmic text that includes this fix? If not, could you provide more details on the typical release process and when we could expect this to be in a stable release? Thanks so much! |
|
I've created a new release, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at fixing #155 and another edge case where two overflowing words next to each other create a shadow run.
Passes all tests and adds a new test.
cc @grovesNL if you wouldn't mind testing this resolves your issue as well.