-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-9235: Added proto changes for supporting smtp tls #273
Conversation
pkg/apis/v1/api.proto
Outdated
// Use custom certificate for SMTP server | ||
bool use_custom_certificate = 9; | ||
// Certificate file content | ||
string cert_file = 10 [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to create a message def for ca cert in common.go and use it where ever required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved to cert content under tlsConfig , placed in common.proto. PTAL
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
OSS Scan Results:
Total issues: 91 |
License Evaluation Results:
Total License Issues: 0 |
What this PR does / why we need it: Added proto changes for supporting input of certs required for smtp
Which issue(s) this PR fixes (optional)
Closes # https://purestorage.atlassian.net/browse/PB-9235
Special notes for your reviewer: