PB-9264: Add isBackupReady_for_PXDLocalSnapshotRestore flag to the … #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgajawada-px
requested review from
siva-portworx,
shkumari-px,
prashanthpx,
vikasit12,
t-nidhin,
px-kesavan,
ss-px,
vsundarraj-px and
a team
…BackupInfo message
|
OSS Scan Results:
Total issues: 91 |
|
License Evaluation Results:
Total License Issues: 0 |
pkg/apis/v1/api.proto
Outdated
| @@ -592,6 +592,8 @@ message BackupInfo { | |||
| bool parallel_backup = 42; | |||
| // option to enable to keep the CR status of the resources in the backup. | |||
| bool keep_cr_status = 43; | |||
| // This will be set when all volumes are PXD and their local snapshots are completed. | |||
| bool are_all_PXDvolumes_localsnapshots_completed = 44; | |||
There was a problem hiding this comment.
Should name it as local_pxd_restore_enabled / local_pxd_restrore_possible?
cc @prashanthpx
|
OSS Scan Results:
Total issues: 91 |
|
License Evaluation Results:
Total License Issues: 0 |
siva-portworx
approved these changes
Jan 19, 2025
pkg/apis/v1/api.proto
Outdated
| @@ -592,6 +592,8 @@ message BackupInfo { | |||
| bool parallel_backup = 42; | |||
| // option to enable to keep the CR status of the resources in the backup. | |||
| bool keep_cr_status = 43; | |||
| // This will be set when all volumes are PXD and their local snapshots are completed. | |||
There was a problem hiding this comment.
nit: This will be set when all volumes are PXD and their local snapshots are completed. ---> This will be set when all volumes are only PXD and their local snapshots are completed and backup is ready for restore from local snapshot.
|
OSS Scan Results:
Total issues: 91 |
|
License Evaluation Results:
Total License Issues: 0 |
sgajawada-px
changed the title
aks-px
pushed a commit
that referenced
this pull request
Jan 22, 2025
…275) * PB-9264: Add isBackupReady_for_PXDLocalSnapshotRestore flag in BackupInfo message
aks-px
pushed a commit
that referenced
this pull request
Jan 22, 2025
…275) * PB-9264: Add isBackupReady_for_PXDLocalSnapshotRestore flag in BackupInfo message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…BackupInfo message
What this PR does / why we need it:
BackupInfo includes a new field isBackupReady_for_PXDLocalSnapshotRestore
Which issue(s) this PR fixes (optional)
Closes #PB-9264
Special notes for your reviewer:
