Skip to content

Commit

Permalink
Revert "see if test is failing because of the tgz missing"
Browse files Browse the repository at this point in the history
This reverts commit 02ab119.
  • Loading branch information
JoviDeCroock committed Aug 3, 2023
1 parent 385d4d7 commit a5754f4
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ jobs:
artifact: npm-package
workflow: ci.yml
required: false
- run: mv preact.tgz preact-master.tgz
- run: mv preact.tgz preact-main.tgz
- name: Upload base preact package
uses: actions/upload-artifact@v3
with:
name: bench-environment
path: preact-master.tgz
path: preact-main.tgz

bench_todo:
name: Bench todo
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-reporter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ jobs:
uses: andrewiggins/tachometer-reporter-action@v2
with:
path: results/*.json
base-bench-name: preact-master
base-bench-name: preact-main
pr-bench-name: preact-local
summarize: 'duration, usedJSHeapSize'
2 changes: 1 addition & 1 deletion benches/proxy-packages/preact-main-proxy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"type": "module",
"main": "index.js",
"dependencies": {
"preact": "file:../../../preact-master.tgz"
"preact": "file:../../../preact-main.tgz"
}
}
2 changes: 1 addition & 1 deletion benches/scripts/bench.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const defaultBenchOptions = {
// GitHub Action minutes
timeout: 1,
'window-size': '1024,768',
framework: IS_CI ? ['preact-master', 'preact-local', 'preact-hooks'] : null,
framework: IS_CI ? ['preact-main', 'preact-local', 'preact-hooks'] : null,
trace: false
};

Expand Down
7 changes: 3 additions & 4 deletions benches/scripts/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,13 @@ export const frameworks = [
}
},
{
label: 'preact-master',
label: 'preact-main',
dependencies: {
framework:
'file:' + repoRoot('benches/proxy-packages/preact-master-proxy')
framework: 'file:' + repoRoot('benches/proxy-packages/preact-main-proxy')
},
async isValid() {
try {
await stat(repoRoot('preact-master.tgz'));
await stat(repoRoot('preact-main.tgz'));
return validateFileDep(this.dependencies.framework);
} catch (e) {
return false;
Expand Down
6 changes: 3 additions & 3 deletions benches/scripts/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ prog
.example('bench text*')
.example('bench *.html')
.example('bench all')
.example('bench many* -f preact-local -f preact-master')
.example('bench many* -f preact-local -f preact-main')
.option(
'--browser, -b',
'Which browsers to launch in automatic mode, comma-delimited (chrome, chrome-headless, firefox, firefox-headless, safari, edge, ie)',
Expand Down Expand Up @@ -72,7 +72,7 @@ prog
// Tests:
// - (no args)
// - many*
// - many* -f preact-local -f preact-master
// - many* -f preact-local -f preact-main
prog
.command('deopts [benchmark]')
.describe(
Expand All @@ -81,7 +81,7 @@ prog
.example('deopts many_updates.html')
.example('deopts many*')
.example('deopts many* -f preact-local')
.example('deopts many* -f preact-local -f preact-master')
.example('deopts many* -f preact-local -f preact-main')
.option(
'--framework, -f',
'The framework to run the benchmark with.',
Expand Down

0 comments on commit a5754f4

Please sign in to comment.