Auction settings id #1100
Open
Auction settings id #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlenaPostindustria
requested changes
Feb 11, 2025
PrebidMobile/AdUnits/AdUnit.swift
Outdated
| if let auctionSettingsId = Prebid.shared.auctionSettingsId, | ||
| auctionSettingsId.isEmpty || auctionSettingsId.containsOnly(.whitespaces) { | ||
| completion(BidInfo(resultCode: .prebidInvalidAuctionSettingsId)) | ||
| return |
There was a problem hiding this comment.
Is it necessary for the SDK to fail the entire fetchDemand process when the optional parameter is invalid? I would suggest logging the error in this case and proceeding with the bid request with the prebidServerAccountId if present.
| @@ -67,8 +67,13 @@ - (void)buildBidRequest:(nonnull PBMORTBBidRequest *)bidRequest { | |||
| BOOL const isHTML = ([adFormats containsObject:AdFormat.banner]); | |||
| BOOL const isInterstitial = self.adConfiguration.adConfiguration.isInterstitialAd; | |||
|
|
|||
| NSString *requestID = self.sdkConfiguration.auctionSettingsId; | |||
There was a problem hiding this comment.
Would be great to have a test when both auctionSettingsId and prebidServerAccountId are present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #946