Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking URL #1112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tracking URL #1112

wants to merge 1 commit into from

Conversation

mdanylov-sigma
Copy link
Collaborator

#954

  • Extends setCustomPrebidServer method with nonTrackingURL parameter.
  • Returns the PBS URL based on ATT status.

OlenaPostindustria
OlenaPostindustria requested changes Feb 28, 2025
View reviewed changes
PrebidMobile/ConfigurationAndTargeting/Prebid.swift
/// - Throws: An error if setting the custom host URL fails.
public func setCustomPrebidServer(url: String) throws {
public func setCustomPrebidServer(url: String, nonTrackingURL: String) throws {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will disrupt the existing integrations. I propose to add a separate method with an extra nonTrackingURL parameter.

@mdanylov-sigma mdanylov-sigma force-pushed the feature/954-tracking-domain branch from c7682f8 to 0948e3b Compare March 3, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlenaPostindustria OlenaPostindustria OlenaPostindustria requested changes

@YuriyVelichkoPI YuriyVelichkoPI Awaiting requested review from YuriyVelichkoPI

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdanylov-sigma @OlenaPostindustria