You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DeviceCommissioner::OnDeviceConnectedFn is ignored if it's not for mDeviceBeingCommissioned. We should do the same with DeviceCommissioner::OnDeviceConnectionFailureFn, because otherwise we might end up calling into CommissioningStageComplete without a valid mDeviceBeingCommissioned and crash with a stack like:
… devices.
Just like we ignore DeviceCommissioner::OnDeviceConnectedFn if the
device id does not match mDeviceBeingCommissioned, we should ignore
OnDeviceConnectionFailureFn.
Fixesproject-chip#22244
… devices. (#22247)
Just like we ignore DeviceCommissioner::OnDeviceConnectedFn if the
device id does not match mDeviceBeingCommissioned, we should ignore
OnDeviceConnectionFailureFn.
Fixes#22244
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this issue
Sep 16, 2022
… devices. (project-chip#22247)
Just like we ignore DeviceCommissioner::OnDeviceConnectedFn if the
device id does not match mDeviceBeingCommissioned, we should ignore
OnDeviceConnectionFailureFn.
Fixesproject-chip#22244
Problem
DeviceCommissioner::OnDeviceConnectedFn
is ignored if it's not formDeviceBeingCommissioned
. We should do the same withDeviceCommissioner::OnDeviceConnectionFailureFn
, because otherwise we might end up calling intoCommissioningStageComplete
without a validmDeviceBeingCommissioned
and crash with a stack like:(on SHA 2e10854 for purposes of line numbers). This is one of the top crashes we are observing in our Matter testing.
which is crashing on the
mDeviceBeingCommissioned
dereference inDeviceCommissioner::CommissioningStageComplete
Proposed Solution
Add the relevant checks.
The text was updated successfully, but these errors were encountered: