Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Darwin APIs should use "ID", not "Id" in names #22528

Closed
bzbarsky-apple opened this issue Sep 11, 2022 · 0 comments · Fixed by #22558
Closed

[Platform] Darwin APIs should use "ID", not "Id" in names #22528

bzbarsky-apple opened this issue Sep 11, 2022 · 0 comments · Fixed by #22558
Assignees
@bzbarsky-apple
Labels
darwin V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 11, 2022 •
edited
Loading

Reproduction steps

Per API review, we should have names ending in "ID", not "Id".

To avoid conflicts, fix this after #18020.

Part of #22420

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple self-assigned this Sep 11, 2022
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 12, 2022
Closed
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 12, 2022
@bzbarsky-apple
Replace "Id" with "ID" in Darwin APIs.
f092b1c 
Fixes project-chip#22528

Addresses part of project-chip#22420
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 12, 2022
Merged
bzbarsky-apple added a commit that referenced this issue Sep 12, 2022
@bzbarsky-apple
Replace "Id" with "ID" in Darwin APIs. (#22558)
6a45e43 
Fixes #22528

Addresses part of #22420
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Replace "Id" with "ID" in Darwin APIs. (project-chip#22558)
b515ce6 
Fixes project-chip#22528

Addresses part of project-chip#22420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace "Id" with "ID" in Darwin APIs. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple