Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fast path for review guidelines #10867

Merged
merged 12 commits into from
Oct 23, 2021
Prev Previous commit
Next Next commit
Updating for fast path rules
woody-apple committed Oct 22, 2021
commit 2bf32a37c9aef183dfe23ef60d2c7816e275961a
41 changes: 24 additions & 17 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ overrides:
- if: "draft or 'WIP' in title"
status: pending
explanation: "PR is draft, pending review"
- if: "not draft"
- if: "draft"
status: pending
explanation: "PR is draft, pending review"

@@ -43,6 +43,13 @@ overrides:
status: failure
explanation: "Style must be inline before reviewing can be complete"

############################################################
# Fast tracking
############################################################
- if: "'fast track' in labels"
status: success
explanation: "PR has been fast tracked, bypassing reviews"

############################################################
# Notifications
############################################################
@@ -89,14 +96,14 @@ groups:
teams: [reviewers-comcast]
reviews:
request: 10
# shared-reviewers-espressif:
# type: optional
# conditions:
# - files.include('*')
# reviewers:
# teams: [reviewers-espressif]
# reviews:
# request: 10
# shared-reviewers-espressif:
# type: optional
# conditions:
# - files.include('*')
# reviewers:
# teams: [reviewers-espressif]
# reviews:
# request: 10
shared-reviewers-google:
type: optional
conditions:
@@ -105,14 +112,14 @@ groups:
teams: [reviewers-google]
reviews:
request: 10
# shared-reviewers-lg:
# type: optional
# conditions:
# - files.include('*')
# reviewers:
# teams: [reviewers-lg]
# reviews:
# request: 10
# shared-reviewers-lg:
# type: optional
# conditions:
# - files.include('*')
# reviewers:
# teams: [reviewers-lg]
# reviews:
# request: 10
shared-reviewers-nordic:
type: optional
conditions: