Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][linux] add ThreadStackManager for Linux Device layer #1147

Closed
wants to merge 2 commits into from

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Jun 17, 2020

Problem

This PR adds ThreadStack manager in the linux device layer.
It relies on otbr-agent as the Thread daemon.

Summary of Changes

  • Implementation of ThreadStackManager
  • DBus connection driver in the event loop
  • Functional tests for ThreadStackManager

fixes #740

Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update a description of what a ThreadStackManager is ?

I see this adding DBus support and I am aware what Thread is, but am missing context of what ThreadStackManager is and what is being built. A brief blurb in the PR would be nice.

Should the title still be WIP or is this ready for rewview and merge?


printf("Start Thread task done\n");

//chip::DeviceLayer::PlatformMgrImpl().RunEventLoop();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove commented out code?

is there any way for this test to fail besides a SIGSEGV? I see it initializing a lot of things but never check any error codes. Can we make it a unit test instead or provide some instructions on how run the test?

@gjc13
Copy link
Contributor Author

gjc13 commented Jun 17, 2020

Could you update a description of what a ThreadStackManager is ?

I see this adding DBus support and I am aware what Thread is, but am missing context of what ThreadStackManager is and what is being built. A brief blurb in the PR would be nice.

Should the title still be WIP or is this ready for rewview and merge?

The ThreadStackManager implementation itself is completed. I open this PR to gather feedback from the community about the Thread solution. Does it look good to use otbr-agent as the Thread daemon and DBus as the IPC mechanism on Linux? I also open it for CI verification and there's still some work to do in the functional tests.

The ThreadStackManager is required for the chip stack to set the network masterkey and other network arguments so as to join a Thread network.

One of the use case is the setup process. User will pass the Thread network information from the phone to a setup server in the chip daemon and it will in turn be passed to _SetThreadProvision in the ThreadStackManager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linux] Linux ConnectivityMgr should support Thread
2 participants